This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Pop out of Threads Activity Centre#12136
Merged
florianduros merged 75 commits intodevelopfrom Feb 7, 2024
Merged
Conversation
florianduros
added
the
T-Enhancement
florianduros
force-pushed
the
florianduros/threads/pop-out-panel
branch
from
a02e9c3 to
6115607
Compare
…ds/pop-out-panel # Conflicts: # src/i18n/strings/en_EN.json
florianduros
force-pushed
the
florianduros/threads/pop-out-panel
branch
from
fdf3843 to
aefe979
Compare
Make the button 32x32 (and the inner icon 24x24)
Fix narrow hover background on TAC button
Add test for the ThreadsActivityCentre component
florianduros
commented
Feb 7, 2024
| * Provides utilities that build on the ability to find messages, e.g. replyTo, | ||
| * which finds a message and then constructs a reply to it. | ||
| */ | ||
| export class MessageBuilder { |
Contributor
Author
There was a problem hiding this comment.
This is basically a lighter version of the read-receipt MessageBuilder.
Copy paste, added mention in thread and removed all the unused parts.
dbkr
approved these changes
Feb 7, 2024
andybalaam
approved these changes
Feb 7, 2024
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks good. I especially like the Playwright tests.
2 tiny comment fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Closes https://github.com/element-hq/wat-internal/issues/144
Figma design
This PR introduces a new way to interact with thread notifications. Following the previous PR #12137 which has added the labs flag and split the unread counts between thread and the main timeline. The threads unreads are now listed in the new Threads Activity Centre (TAC) which is located on the bottom left of Element Web, in the Spaces panel.
The TAC can be opened by clicking on the thread icon in the Spaces Panel:
The TAC is a pop out:
red > green > black/white)Examples
Opening the TAC
Clicking on the room
testin the TACOpening the thread with a mention in the room
testand opening again the TAC. Both the TAC icon button and the room indicator have been updated to reflect the new state of the thread unreadsIncluded PRs
Here's what your changelog entry will look like:
✨ Features